Run missing tests #37819
Merged
Run missing tests #37819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR 32393, the `GMOCK_TEST_FILES` accidentally went missing from `Framework/API/test/CMakeLists.txt`, this adds it back in, and edits `MatrixWorkspaceTest` to make it run again.
jclarkeSTFC
added
Bug
cailafinn
requested changes
Aug 20, 2024
This code was supposed to return the last time if none of the times are after 1991, but the index was one greater than it should be if no suitable times were found. Co-authored-by: Jonathan Haigh <jonathan.haigh@stfc.ac.uk>
jclarkeSTFC
force-pushed
the
run_missing_tests_matrixWorkspacetest
branch
from
e77349d to
909f00a
Compare
cailafinn
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit,
${GMOCK_TEST_FILES}went missing when the tests are added, which meansImplicitFunctionFactoryTest,ImplicitFunctionParameterParserFactoryTest, andMatrixWorkspaceTesthaven't been run for 3 years.One of the tests in
MatrixWorkspaceTestspotted a (niche) bug, which is also fixed in this PR. If there are no times in your sample log after 1991, then instead of returning the last time, it was indexing the memory outside the range of the time vector.To test:
The tests mentioned above should run.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.