Skip to content

Conversation

sf1919
Copy link
Contributor

@sf1919 sf1919 commented Aug 19, 2024

Description of work

Summary of work

Have made it so that the build will no longer use v0.3.28 of libopenblas

Purpose of work

Lots of PRs failing on unrelated tests as well as the nightly. The only dependency change has been libopenblas. Blocking this newest version seems to have allowed all tests to pass on this PR.

There is no associated issue.

Further detail of work

Changes to the conda recipe to avoid v0.3.28 of libopenblas

To test:

  • all CI tests should pass
  • Check that v0.3.28 of libopenblas is no longer being used

This does not require release notes because *it is a dependency pin


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@sf1919 sf1919 added this to the Release 6.11 milestone Aug 20, 2024
@sf1919 sf1919 added DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Aug 20, 2024
@sf1919 sf1919 marked this pull request as ready for review August 20, 2024 06:43
@sf1919
Copy link
Contributor Author

sf1919 commented Aug 20, 2024

Once this goes in you will probably want to add it to ornl-next @peterfpeterson

@sf1919
Copy link
Contributor Author

sf1919 commented Aug 20, 2024

I didn't add a note to say why v0.3.28 is being avoided in the recipes etc. Given how much this is blocking I will do it as a separate PR if thats ok?

Copy link
Contributor

@cailafinn cailafinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin looks good. Builds fine. Explanation will be added later.

Do we need to update the Dependency Failures spreadsheet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants