Skip to content

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Aug 19, 2024

Description of work

This PR fixes a bug on the ISIS Diagnostics tab of the Indirect Data Reduction interface where the incorrect load algorithm was being used to load a raw file. The assumption was that the LoadNexusProcessed algorithm should be used if the LoadHistory=true property was provided. Instead, we should rely on the Load algorithm to choose the correct loader, and then only set the LoadHistory property if this property exists on the chosen load algorithm.

Fixes #37808

No tests have been added because this part of the code is not in MVP.

To test:

  1. Open Indirect Data Reduction
  2. Select IRIS instrument
  3. Go to ISIS Diagnostics tab
  4. Type in 26176 and press enter
  5. The data will load and a graph plotted in the embedded interface plot.
  6. There should be NO red asterisk next to the File selector widget.

This does not require release notes because the bug was introduced after the last stable release of Mantid

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS labels Aug 19, 2024
@robertapplin robertapplin added this to the Release 6.11 milestone Aug 19, 2024
@robertapplin robertapplin marked this pull request as ready for review August 19, 2024 15:39
Copy link
Contributor

@warunawickramasingha warunawickramasingha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as explained! Happy to approve if the tests are passing!

@SilkeSchomann SilkeSchomann self-assigned this Aug 21, 2024
@SilkeSchomann SilkeSchomann merged commit 43d94be into mantidproject:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Indirect ISIS Diagnostics unable to load file
3 participants