Compression options for AlignAndFocusPowderFromFiles #37831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
requested changes
Aug 19, 2024
There was a problem hiding this comment.
This missed the mark. The request was "AlignAndFocusPowderFromFiles needs additional parameter(s) to determine whether its call to LoadEventNexus should enable compressing events during load." When it is determined that the file should be compressed on load, the parameters CompressTolerance and CompressBinningMode need to be supplied to LoadEventNexus. The __compressEvents() method is called by the __accummlate() method which is run after a chunk is processed. These methods should not be modified.
This is also missing release notes.
dmitry-ganyushin
force-pushed
the
compression-options
branch
from
abd1b62 to
481c7ca
Compare
Framework/PythonInterface/plugins/algorithms/AlignAndFocusPowderFromFiles.py
Outdated
Show resolved
Hide resolved
peterfpeterson
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6060: Add load w/ compression parameters to AlignAndFocusPowderFromFiles
Description of work
Added an additional parameter AlignAndFocusPowderFromFiles to determine whether its call to LoadEventNexus should enable compressing events during load. The parameter is called "MinSizeCompressOnLoad" which is a floating point number of Gbytes.
.