Skip to content

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Aug 20, 2024

This was pointed out in #35837 and apparently by cppcheck (which was suppressed).

There is no associated issue.

Further detail of work

To test:

A code review is probably the best way to verify this.

This does not require release notes because nothing appears to set only one of the values.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added this to the Release 6.11 milestone Aug 20, 2024
@peterfpeterson peterfpeterson changed the title Fixing check to be start/stop FitPeaks - fixing check to be start/stop Aug 20, 2024
Copy link
Contributor

@MohamedAlmaki MohamedAlmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small issue that's been hidden by a CPP suppression

@SilkeSchomann SilkeSchomann self-assigned this Aug 21, 2024
@SilkeSchomann SilkeSchomann merged commit 3644746 into mantidproject:main Aug 21, 2024
@peterfpeterson peterfpeterson deleted the pdcalibration_bugfix branch August 21, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants