Skip to content

Conversation

cailafinn
Copy link
Contributor

Description of work

Summary of work

Alter the wording of the tooltips to make them clearer for people to understand.

Fixes #37827

Further detail of work

Improves two of the tooltips to clarify how the checkbox and line edit work.

To test:

  1. Open the ISIS SANS Interface
  2. Navigate to Settings
  3. Check the tooltips have been updated as stated in the issue.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added SANS Issues and pull requests related to SANS ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS labels Aug 20, 2024
@cailafinn cailafinn added this to the Release 6.11 milestone Aug 20, 2024
@rbauststfc rbauststfc self-assigned this Aug 21, 2024
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Tooltip wording has been updated and is displaying correctly in the ISIS SANS interface.

@SilkeSchomann SilkeSchomann self-assigned this Aug 21, 2024
@SilkeSchomann SilkeSchomann merged commit 5ebdf08 into mantidproject:main Aug 21, 2024
10 checks passed
@cailafinn cailafinn deleted the 37827_isis_sans_tooltips branch August 21, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS SANS Issues and pull requests related to SANS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve accuracy of ISIS SANS interface Settings tab tooltips
3 participants