From 241d4cfb2f5af22389e77a8da632ab88149e17fb Mon Sep 17 00:00:00 2001 From: Pete Peterson Date: Tue, 20 Aug 2024 12:04:10 -0400 Subject: [PATCH] Fixing check to be start/stop This was pointed out in #35837 --- Framework/Algorithms/src/FitPeaks.cpp | 2 +- buildconfig/CMake/CppCheck_Suppressions.txt.in | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Framework/Algorithms/src/FitPeaks.cpp b/Framework/Algorithms/src/FitPeaks.cpp index 6e1189e4309a..ee5500207810 100644 --- a/Framework/Algorithms/src/FitPeaks.cpp +++ b/Framework/Algorithms/src/FitPeaks.cpp @@ -445,7 +445,7 @@ std::map FitPeaks::validateInputs() { map issues; // check that min/max spectra indices make sense - only matters if both are specified - if (!(isDefault(PropertyNames::START_WKSP_INDEX) && isDefault(PropertyNames::START_WKSP_INDEX))) { + if (!(isDefault(PropertyNames::START_WKSP_INDEX) && isDefault(PropertyNames::STOP_WKSP_INDEX))) { const int startIndex = getProperty(PropertyNames::START_WKSP_INDEX); const int stopIndex = getProperty(PropertyNames::STOP_WKSP_INDEX); if (startIndex > stopIndex) { diff --git a/buildconfig/CMake/CppCheck_Suppressions.txt.in b/buildconfig/CMake/CppCheck_Suppressions.txt.in index f97a6d334f6e..8a408dbd8c8c 100644 --- a/buildconfig/CMake/CppCheck_Suppressions.txt.in +++ b/buildconfig/CMake/CppCheck_Suppressions.txt.in @@ -260,7 +260,6 @@ knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeaks.c unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/InterpolatingRebin.cpp:69 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetEi2.cpp:213 missingOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/GetAllEi.h:32 -duplicateExpression:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FitPeaks.cpp:448 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetTimeSeriesLogInformation.cpp:277 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetTimeSeriesLogInformation.cpp:501 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetTimeSeriesLogInformation.cpp:248