Skip to content

Conversation

sf1919
Copy link
Contributor

@sf1919 sf1919 commented Aug 23, 2024

Description of work

Removal of FindUBUsingMinMaxD Algorithm as this has been deprecated in 2013.

Summary of work

Remove FindUBUsingMinMaxDs, FindUBUsingMinMaxDTest and associated files from Mantid Code base.

This PR also removes references from CMake and documentation references from v6.1.0 release notes for diffraction.

Part of #31258

Further detail of work

Deprecated as part of commit #b65b56e

To test:

  • tests should pass
  • Check correct files have been removed (algorithm & tests)
  • Check correct lines have been removed from CMake
  • Check there are no further links/references to FindUBUsingMinMaxD in the code base

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

sf1919 added 3 commits August 22, 2024 16:22
- Remove algorithm inc and src files
- Update Cmake list
- Remove test file
- Update CMakeLists
- Remove documentation for algorithm
- Remove link from v6.1.0 Diffraction release notes
@sf1919 sf1919 added Diffraction Issues and pull requests related to diffraction ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions labels Aug 23, 2024
@sf1919 sf1919 added this to the Release 6.11 milestone Aug 23, 2024
@sf1919 sf1919 marked this pull request as ready for review August 23, 2024 13:01
@sf1919 sf1919 added the Framework Issues and pull requests related to components in the Framework label Aug 23, 2024
@RichardWaiteSTFC RichardWaiteSTFC self-assigned this Aug 28, 2024
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think there are still some references to FindUBUsingMinMaxD in related algorithms that should be removed

return {"SetUB", "FindUBUsingIndexedPeaks", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"};

return {"SetUB", "FindUBUsingFFT", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"};

return {"SetUB", "FindUBUsingFFT", "FindUBUsingIndexedPeaks", "FindUBUsingMinMaxD"};

return {"FindUBUsingFFT", "FindUBUsingIndexedPeaks", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"};

- Removed from FindUBUsingFFT documentation
- Removed from FindUBUsingIndexedPeaks documentation
- Removed from FindUBUsingLatticeParameters documentation
- Removed from SetUB documentation
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and CI passes so approving!

@thomashampson thomashampson self-assigned this Sep 3, 2024
@thomashampson thomashampson merged commit 338b61a into main Sep 3, 2024
10 checks passed
@thomashampson thomashampson deleted the 31258_FindUBUsingMinMaxD branch September 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Framework Issues and pull requests related to components in the Framework ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants