-
Notifications
You must be signed in to change notification settings - Fork 128
Remove FindUBUsingMinMaxD algorithm #37864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Remove algorithm inc and src files - Update Cmake list
- Remove test file - Update CMakeLists
- Remove documentation for algorithm - Remove link from v6.1.0 Diffraction release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, I think there are still some references to FindUBUsingMinMaxD
in related algorithms that should be removed
return {"SetUB", "FindUBUsingIndexedPeaks", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"}; |
return {"SetUB", "FindUBUsingFFT", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"}; |
return {"SetUB", "FindUBUsingFFT", "FindUBUsingIndexedPeaks", "FindUBUsingMinMaxD"}; |
return {"FindUBUsingFFT", "FindUBUsingIndexedPeaks", "FindUBUsingLatticeParameters", "FindUBUsingMinMaxD"}; |
- Removed from FindUBUsingFFT documentation - Removed from FindUBUsingIndexedPeaks documentation - Removed from FindUBUsingLatticeParameters documentation - Removed from SetUB documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and CI passes so approving!
Description of work
Removal of FindUBUsingMinMaxD Algorithm as this has been deprecated in 2013.
Summary of work
Remove FindUBUsingMinMaxDs, FindUBUsingMinMaxDTest and associated files from Mantid Code base.
This PR also removes references from CMake and documentation references from v6.1.0 release notes for diffraction.
Part of #31258
Further detail of work
Deprecated as part of commit #b65b56e
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.