Remove FilterEventsByLogValuePreNexus Algorithm #37865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sf1919
added
the
ISIS: Core
8 tasks
sf1919
added
the
Framework
|
👋 Hi, @sf1919, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
github-actions
bot
added
the
Has Conflicts
- remove header and main files - Update Cmake list
- Remove test file - Update CMake list
- Remove FilterEventsByLogValuePreNexus v2 documentation - Replace use of FilterEventsByLogValuePreNexus as an example in sphinx directives with FindEPP - Update LoadEventPreNexus2 to not refer to FilterEventsByLogValuePreNexus
- Remove unncessary suppressions for FilterEventsByLogValuePreNexus
sf1919
force-pushed
the
31258_FilterEventsByLogValuePreNexus
branch
from
3bed027 to
390c835
Compare
github-actions
bot
removed
the
Has Conflicts
cailafinn
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Removal of FilterEventsByLogValuePreNexus Algorithm as this has been deprecated in 2014.
Summary of work
Remove FilterEventsByLogValuePreNexus, FilterEventsByLogValuePreNexusTest and associated files from Mantid Code base.
This PR also removes references from CMake and documentation references in the sphinx docs directive and LoadEventPreNexus2 algorithm.
Part of #31258
Further detail of work
Deprecated as part of commit 3e256c4
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.