Skip to content

PG3StripPeaks to not use AlignDetectors algorithm #37872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

PG3StripPeaks to not use AlignDetectors algorithm #37872

merged 1 commit into from
Aug 28, 2024

Conversation

dmitry-ganyushin
Copy link
Collaborator

@dmitry-ganyushin dmitry-ganyushin commented Aug 23, 2024 •
edited
Loading

6890: Update PG3StripPeaks to not use AlignDetectors algorithm

Description of work

Fixes #37859

SNSPowderRedux.PG3StripPeaks should no longer use AlignDetectors algorithm.
The proposed change is centered on L219. Currently,

AlignDetectors(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", OffsetsWorkspace="PG3_offsets")
ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="TOF")

should become

ApplyDiffCal(InstrumentWorkspace="PG3_4866", OffsetsWorkspace="PG3_offsets")
ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="dSpacing")
ApplyDiffCal(InstrumentWorkspace="PG3_4866", ClearCalibration=True) ConvertUnits(InputWorkspace="PG3_4866", OutputWorkspace="PG3_4866", Target="TOF")

Release note is missing because a system test is modernized.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Aug 26, 2024
@peterfpeterson peterfpeterson added this to the Release 6.11 milestone Aug 26, 2024
@dmitry-ganyushin dmitry-ganyushin mentioned this pull request Aug 26, 2024
Closed
@sf1919 sf1919 merged commit 0504e90 into main Aug 28, 2024
@sf1919 sf1919 deleted the Update-PG3StripPeaks branch August 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfpeterson peterfpeterson peterfpeterson approved these changes

Assignees
No one assigned
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Milestone
Release 6.11
Development

Successfully merging this pull request may close these issues.

Update PG3StripPeaks to not use AlignDetectors algorithm
3 participants
@dmitry-ganyushin @peterfpeterson @sf1919