Skip to content

Conversation

adriazalvarez
Copy link
Contributor

Description of work

Fixes the latest auto cause copy coverity warnings.

There is no associated issue.

Further detail of work

To test:

  • Code review

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin self-assigned this Aug 28, 2024
@robertapplin robertapplin added ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Maintenance Unassigned issues to be addressed in the next maintenance period. labels Aug 28, 2024
@robertapplin robertapplin added this to the Release 6.11 milestone Aug 28, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these coverity warnings. The code changes look good, and it is enough that the tests are all passing

@robertapplin robertapplin marked this pull request as ready for review August 28, 2024 15:28
@peterfpeterson peterfpeterson merged commit 00f4f6f into main Aug 28, 2024
1 check passed
@peterfpeterson peterfpeterson deleted the coverity_Warning branch August 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants