Skip to content

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Aug 30, 2024

Report to: Mona Sarter

Description of work

This PR fixes a bug in the BayesQuasi algorithm where an "index out of range" error would show when using a sample or vanadium with a NumericAxis rather than a SpectraAxis. ILL data has a NumericAxis, so this should make it possible to use this interface with this ILL data.

The problem was with the incorrect extraction of the Q values from the NumericAxis. It was previously calculating the centre value, but this was not necessary.

There is no associated issue.

To test:

  1. Open Inelastic Bayes Fitting interface

  2. Go to the Quasi tab

  3. Load the following data as Sample and resolution. (You might need to unrestrict data by name in the Settings dialog)
    BCA299_Subtract.zip
    vanadium.zip

  4. Click Run. If you get a pop-up, click Yes

  5. The algorithm should run to completion. Previously a red error message would appear in the log saying "index out of range"

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS Reported By User Issues that were found or highlighted by a user/scientist labels Aug 30, 2024
@robertapplin robertapplin added this to the Release 6.11 milestone Aug 30, 2024
@robertapplin robertapplin marked this pull request as ready for review September 1, 2024 09:26
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test works with no error, code changes look good :)

@jhaigh0 jhaigh0 self-assigned this Sep 3, 2024
@thomashampson thomashampson self-assigned this Sep 3, 2024
@thomashampson thomashampson merged commit 6d2b425 into mantidproject:main Sep 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants