-
Notifications
You must be signed in to change notification settings - Fork 128
Add a System Test for the DepolarizedAnalyserTransmission Algorithm #37899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a System Test for the DepolarizedAnalyserTransmission Algorithm #37899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can see the test runs fine in the ci job. One very minor readability thing
...g/SystemTests/tests/framework/PolarizationCorrections/DepolarizedAnalyserTransmissionTest.py
Outdated
Show resolved
Hide resolved
The algorithm is supposed to take two matrixworkspaces, rather than a group. This empty cell workspace needs to be averaged, as it is a group. RE mantidproject#37120
37b6741
to
1354494
Compare
1354494
to
eaf12e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easier for the algorithms in the test to use StoreInADS=False
and then just assign the results to python variables?
If you want to use the ADS, is it easier to just clear the ADS in the cleanup
method, rather than delete each test by name?
Ah, thanks for the heads up, that's a better solution. I was hesitant to just clear the ADS so it didn't clear other tests. But thinking about it, I don't think they run on the same instance of the framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go, the test failure in the CI is unrelated
5f530d2
to
b8b406f
Compare
Description of work
Summary of work
Add a system test to check the algorithm works consistently across OS' with real data files.
Fixes #37120
Further detail of work
Also adds the associated data files for running the algorithm properly. The code is set to ignore the error in the fit being quite high. This is intentional.
To test:
./build/systemtest -R DepolarizedAnalyserTransmission
script.SystemTestData
target manually may be required.This does not require release notes because there are no user-facing changes.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.