Add tests for IqtPresenter tab #37901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriazalvarez
added
ISIS: Spectroscopy
warunawickramasingha
requested changes
Sep 5, 2024
adriazalvarez
force-pushed
the
test_iqt_presenter
branch
from
b7f56ef to
45901ad
Compare
qt/scientific_interfaces/Inelastic/test/Processor/IqtPresenterTest.h
Outdated
Show resolved
Hide resolved
warunawickramasingha
approved these changes
Sep 18, 2024
mpatrou
pushed a commit
that referenced
this pull request
Nov 21, 2024
This is a squashed version of #37901 Add test for IqtPresenter, and mocks for Iqtmodel and view Eliminate unused funciton in IqtPresenter Remove unnecesary virtual functions override data processor destructor to make it virtual
mpatrou
added a commit
that referenced
this pull request
Nov 25, 2024
Add tests for IqtPresenter tab #37901 Elwin allow processing ILL data #38033 Update Qt connection syntax in Inelastic Interfaces #38119 Update Moments tab instructions and add more tests #38274 Construct the model of OutputPlotOptions widget outside the Presenter class. #38289 Add identifier for output workspaces in Elwin Interface #37762 MVP for the ResNorm tab of the Inelastic Bayes Fitting interface #38357 Remove deprecated Calculate Paalman Pings tab from Inelastic Corrections #38391 Use std::pair instead of QPair in utility files #38396 Elwin Elastic line integration issue #38392 --------- Co-authored-by: adriazalvarez <adrian.diaz-alvarez@stfc.ac.uk> Co-authored-by: Applin <robert.applin@stfc.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Add unit tests for the IqtPresenter class. This issue is part of #36582
Summary of work
Fixes #37890 .
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.