Fix startup tests #37925
Merged
Fix startup tests #37925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a build packages from branch run as the failing systems tests don't run on Windows or OSX as part of normal PR testing |
Since we switched to pip install --editable instead of calling setup.py directly, we no longer get an executable file in the build output, so this test needed adjusting. It was also attempting to do a for loop and returning at the first entry so we fixed that. Co-authored-by: Jonathan Haigh <jonathan.haigh@stfc.ac.uk>
jclarkeSTFC
force-pushed
the
startup_test_fix
branch
from
056e996 to
77a832d
Compare
This was never tested previously, and the dev build does not create a mantidworkbench entry point, conda-build does that, hence I've deleted it.
jclarkeSTFC
added
High Priority
The startup script isn't going to exist any more, so change the command used for debugging workbench.
jhaigh0
reviewed
Sep 9, 2024
jhaigh0
previously approved these changes
Sep 9, 2024
jhaigh0
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to
pip install --editableinstead of callingsetup.pydirectly (#37775), we no longer get an executable file in the build output, so this test needed adjusting. It was also attempting to do a for loop and returning at the first entry so we fixed that.On Linux it was trying to test
mantidworkbenchas an entry point but:mantidworkbenchentry point is created byconda-build, not when you do a dev build, so this wouldn't have worked previously anyway.To test:
https://builds.mantidproject.org/job/build_packages_from_branch/876/
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.