Skip to content

Conversation

@thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Sep 12, 2024

Description of work

Increase external data download timeout from 600 o 1200 seconds. It timed out on a ~250 mb file, so I double it to give it a chance to download a ~500 mb file.

There is no associated issue.

To test:

External data should download in the linux PR check.

This does not require release notes because it's a change to cmake config


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Sep 12, 2024
@thomashampson thomashampson added this to the Release 6.11 milestone Sep 12, 2024
@thomashampson thomashampson added DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Sep 12, 2024
@thomashampson thomashampson marked this pull request as ready for review September 12, 2024 08:18
@sf1919 sf1919 self-assigned this Sep 12, 2024
@sf1919
Copy link
Contributor

sf1919 commented Sep 12, 2024

I'm a bit confused by this as I thought the failure in the docs had been resolved in #37908

Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux PR job passed. The doctest failure is clearly unrelated. This PR is needed to fix at leat one other.

@SilkeSchomann SilkeSchomann self-assigned this Sep 12, 2024
@sf1919 sf1919 merged commit 7677a68 into main Sep 12, 2024
@sf1919 sf1919 deleted the increase_externaldata_timeout branch September 12, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants