Skip to content

Conversation

RichardWaiteSTFC
Copy link
Contributor

Description of work

Following on from PR #37929 - this is a small refactor to make the main method a bit smaller.

Fixes #37969

To test:

(1) CI passes
(2) Follow instructions in previous PR #37929

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@RichardWaiteSTFC RichardWaiteSTFC added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Sep 12, 2024
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.12 milestone Sep 12, 2024
@RichardWaiteSTFC RichardWaiteSTFC added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction ISIS: Diffraction Issue and pull requests relating to Diffraction at ISIS labels Sep 16, 2024
Copy link
Contributor

@MohamedAlmaki MohamedAlmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have tried the script and it is working as expected. I have small comments about confusing expressions. Thanks for refactoring the code, which improved the readability of the code

As requested during PR review
Copy link
Contributor

@MohamedAlmaki MohamedAlmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the refactoring which improved the code readability!

@SilkeSchomann SilkeSchomann self-assigned this Oct 11, 2024
@SilkeSchomann SilkeSchomann merged commit b698691 into main Oct 11, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 37969_refactor_HRPD_prompt_pulse_subtraction_func_for_readability branch October 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction ISIS: Diffraction Issue and pull requests relating to Diffraction at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Powder Issues and pull requests related to powder diffraction
Projects
Status: Merged
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor HRPD prompt pulse fitting/subtraction for readability
3 participants