Skip to content

Conversation

robertapplin
Copy link
Contributor

Description of work

This PR ensures the Preview Workspace combobox in Elwin has a dynamic size which adjusts according to the size of the GUI. This prevents the name of the selected workspace above the embedded plot from being cut off unnecessarily.

Fixes #38034

To test:

  1. Interfaces->Inelastic->Data Processor
  2. Go to Elwin tab
  3. Check the QComboBox takes up most the space above the Embedded plot

This does not require release notes because it is a regression.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin changed the base branch from main to release-next September 19, 2024 12:51
@robertapplin robertapplin added ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS GUI Issues and pull requests specific to the Mantid Workbench GUI. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Reported By User Issues that were found or highlighted by a user/scientist labels Sep 19, 2024
@robertapplin robertapplin added this to the Release 6.11 milestone Sep 19, 2024
@robertapplin robertapplin marked this pull request as ready for review September 19, 2024 12:52
Copy link
Contributor

@cailafinn cailafinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested on macOS. Size of combobox is no longer limited and fills the space properly. Code changes look good.

@rbauststfc rbauststfc self-assigned this Sep 25, 2024
@rbauststfc rbauststfc merged commit c1d6fd2 into mantidproject:release-next Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) GUI Issues and pull requests specific to the Mantid Workbench GUI. ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Preview Workspace combobox on Elwin is too small
3 participants