Skip to content

Conversation

adriazalvarez
Copy link
Contributor

Description of work

This PR adds the correct file path for the calculator example files on the recently refurbished MVP tutorial: #37953

The warnings is the following:
https://builds.mantidproject.org/job/build_and_publish_developer_site/1091/sphinx/source.cf0fecd4-b32a-475f-92f5-355421641a61/#10

Further detail of work

To test:

  • No sphinx build warnings should appear on the CI.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@adriazalvarez adriazalvarez added the Documentation Issues and pull requests related to documentation label Sep 20, 2024
@adriazalvarez adriazalvarez added this to the Release 6.12 milestone Sep 20, 2024
@robertapplin robertapplin self-assigned this Sep 20, 2024
@adriazalvarez adriazalvarez marked this pull request as ready for review September 20, 2024 12:56
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks good to me! No documentation warnings are in the CI jobs

@SilkeSchomann SilkeSchomann self-assigned this Sep 20, 2024
@SilkeSchomann SilkeSchomann merged commit 2d44091 into main Sep 20, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the mvp_fileName branch September 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants