-
Notifications
You must be signed in to change notification settings - Fork 128
Use ruff to check for wild imports #38068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b6e64a2
to
c5c5372
Compare
1c0cf72
to
00a40aa
Compare
00a40aa
to
62d5da1
Compare
e0dcecb
to
f09fc8e
Compare
f09fc8e
to
f9497a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused why I'm not seeing the changes to the pyproject from this commit 944c561 when looking at the Files Changed tab.
I've decided to do this ruff wild import conversion in two parts to reduce the size of the PR. For now there are still many wild import warnings in Mantid, so I have not made changes to the pyproject.toml until the next PR which I hope will finish off all wild import changes |
cd0e324
to
2104ee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good now
$ pre-commit run ruff --all-files
ruff.....................................................................Passed
Description of work
This PR is a first step towards enabling the check for wild imports in the pre-commit ruff configuration. This PR is only the first step, and future PRs will be opened to remove wild imports elsewhere. The wild-import check will then be enabled in the pyproject.toml by removing
F403
.This is ready for review.
To test:
Code review - check that all imports look correct.
Run ruff locally on all files using the following terminal command
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.