Skip to content

Conversation

jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Sep 25, 2024

Use std::filesystem methods and classes instead of Poco in the code loading dynamic libraries. Also threw in replacing boost string methods with std equivalents in DllOpen.cpp.

Related to #37868

To test:

Check libraries are loaded correctly by setting logging to Debug and checking that e.g. MantidCrystal.dll is loaded, along with all other .dll files in the bin folder. In a package some of those files will appear in the plugins folder.

This does not require release notes because it has no effect on the user.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Use std::filesystem methods and classes instead of Poco in the code
loading dynamic libraries. Also threw in replacing boost string
methods with std equivalents in DllOpen.cpp.
@jclarkeSTFC jclarkeSTFC added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Sep 25, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.11 milestone Sep 25, 2024
@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review September 26, 2024 07:23
@jclarkeSTFC jclarkeSTFC modified the milestones: Release 6.11, Release 6.12 Oct 1, 2024
@jclarkeSTFC jclarkeSTFC changed the base branch from release-next to main October 1, 2024 15:19
@jclarkeSTFC jclarkeSTFC added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Oct 1, 2024
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in debug mode and all working fine. Although this PR wasn't needed in the end, it removes some Poco and Boost usage in favour of stl equivalents, so let's get it in.

@sf1919 sf1919 self-assigned this Oct 29, 2024
@sf1919 sf1919 merged commit 86eb2f1 into mantidproject:main Oct 29, 2024
10 checks passed
@jclarkeSTFC jclarkeSTFC deleted the use_std_filesystem_in_library_loading branch October 30, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants