Skip to content

Conversation

MohamedAlmaki
Copy link
Contributor

Description of work

This PR fixes a crash in the ISIS Calibration and ISIS Diagnostics tabs. The crash is caused by multiple calls to the setIndices slot, which updates the text of the plot indices line edit. This PR provides a quick solution for the release by disabling the ADS observer while running the algorithms to avoid multiple simultaneous updates.

Fixes #38078.

To test:

Follow #38078

This does not require release notes because regression bug introduced in this release


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@MohamedAlmaki MohamedAlmaki added Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS labels Sep 27, 2024
@MohamedAlmaki MohamedAlmaki added this to the Release 6.11 milestone Sep 27, 2024
@rbauststfc rbauststfc self-assigned this Sep 27, 2024
@MohamedAlmaki MohamedAlmaki added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Sep 27, 2024
@MohamedAlmaki MohamedAlmaki changed the base branch from main to release-next September 27, 2024 14:28
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I've tested both sets of steps on the linked issue and there are no crashes. Great job getting to the bottom of this one, it sounded tricky to diagnose!

@robertapplin robertapplin self-assigned this Sep 30, 2024
@robertapplin robertapplin merged commit d81f4f0 into release-next Sep 30, 2024
10 checks passed
@robertapplin robertapplin deleted the 38078-fix-crash-plot-options branch September 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Crash Due to Random Access Violation Error in OutputPlotOptionsView::setIndices
3 participants