Change members of EventList from value to unique_ptr #38108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
added
the
Maintenance
peterfpeterson
force-pushed
the
event_unique_ptr
branch
5 times, most recently
from
19e3ef5 to
88d9b7b
Compare
rosswhitfield
requested changes
Oct 2, 2024
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
github-actions
bot
added
the
Has Conflicts
This change will save memory because the underlying vectors of events that aren't used will be nullptr rather than vector of default capacity.
peterfpeterson
force-pushed
the
event_unique_ptr
branch
from
88d9b7b to
c51fc5b
Compare
peterfpeterson
removed
the
Has Conflicts
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
removed
the
Has Conflicts
rosswhitfield
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will save memory because the underlying vectors of events that aren't used will be nullptr rather than vector of default capacity.
This also moves two cppcheck suppressions to be inline (they'll never go away) and fixes the others in
DataObjects::EventList.There is no associated issue, but this is associated with EWM7462
To test:
This is a refactor to be more efficient in releasing memory. The changes to
EventListTestadd more checks which aided in tracking down nullptr dereferencing errors.This does not require release notes because it is an isolated code refactor. There should be very little difference to the user other than less memory is used by EventWorkspaces with many spectra.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.