Re add rotatesampleshape #38115
Merged
Re add rotatesampleshape #38115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warunawickramasingha
added
High Priority
warunawickramasingha
force-pushed
the
re_add_rotatesampleshape
branch
from
71897eb to
e7f7daf
Compare
|
@RichardWaiteSTFC Could you please use the installers from https://builds.mantidproject.org/job/build_packages_from_branch/917/ run to test this issue? Thanks! |
There was a problem hiding this comment.
Looks good to me - tested original PR instructions and works as expected using standalone installed version on windows. No import warnings for MantidCrystal or DataHandling algorithms. Not approving yet as waiting for @thomashampson to test on linux (thanks!).
thomashampson
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This fix was added to not to import and reuse a method from Mantid::DataHandling library by linking with target_link_libraries in cmake which had caused some weird import errors on some Operating systems and to caused to miss some Crystal algorithms.
In this PR, the method that was required to be imported which was a only a small number of lines, was copied into RotateSampleShape class rather than reusing.
Further detail of work
To test:
The problem only appears when using a standalone installer, not a conda install (don't know why). The following build will create standalone installers for all OS, use them to test:
https://builds.mantidproject.org/job/build_packages_from_branch/917/
1- Follow the testing instructions as mentioned in #37908
2- Check for any startup errors or any missing Crystal libraries in different OSs specially on Linux
Release notes were not added since this is just an internal fix.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.