Add gsas2 unit tests #38123
Merged
Add gsas2 unit tests #38123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the basic structure for the unit tests of call_G2sc.py. Had to wrap code in call_G2sc.py in a main() function so can import functions from file without triggering the entire routine.
Decided to create this function because if add_histograms exists then it makes sense for add_phases to exist as well
Added unit test for functions that write to directory. Set up class and tear down to clean temporary directory.
GuiMacielPereira
added
Maintenance
RichardWaiteSTFC
requested changes
Oct 18, 2024
...mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/test/test_call_G2sc.py
Outdated
Show resolved
Hide resolved
...nterfaces/mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/call_G2sc.py
Show resolved
Hide resolved
...mantidqtinterfaces/Engineering/gui/engineering_diffraction/tabs/gsas2/test/test_call_G2sc.py
Outdated
Show resolved
Hide resolved
Handled creation of temporary file with tempfile library
Put repeated line for setting up project inside setUp function
RichardWaiteSTFC
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Originally the issue was to add tests to the view of gsas2, but I did not see a case for it when most of the test cases would have just been
mock.assert_called(). Instead I added tests for thecall_G2sc.pyfile, which passes mantid inputs into a GSAS2 script.Summary of work
Added unit tests to functions on
call_G2sc.pyfile.Fixes #35624 .
Further detail of work
To test:
Code review and do at least one GSAS refinement on the Eng Diff interface.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.