Include schema files in Linux standalone #38161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclarkeSTFC
added
Bug
jclarkeSTFC
force-pushed
the
38160_standalone_launcher_fix_linux
branch
3 times, most recently
from
866f5e5 to
ec21b59
Compare
jclarkeSTFC
force-pushed
the
38160_standalone_launcher_fix_linux
branch
3 times, most recently
from
295305a to
61ab1a3
Compare
If we don't include these schema files and set the appropriate environment variable, then the standalone will use the system schema files. If these are not compatible with the current versions of packages that we use, then we can get an error.
jclarkeSTFC
force-pushed
the
38160_standalone_launcher_fix_linux
branch
from
61ab1a3 to
e0add82
Compare
jhaigh0
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't include these schema files and set the appropriate environment variable, then the standalone will use the system schema files. If these are not compatible with the current versions of packages that we use, then we can get an error.
Fixes #38160.
For more info see here and here.
To test:
Check a conda install and a standalone on IDAaaS (and maybe another Linux machine if you have one available).
https://builds.mantidproject.org/job/build_packages_from_branch/926/
install conda package with:
mamba install -c thomashampson/label/linuxstandalonefix mantidworkbenchReviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.