Skip to content

Conversation

searscr
Copy link
Contributor

@searscr searscr commented Oct 8, 2024

Description of work

This includes the DPROFILE_ALGORITHM_LINUX=ON cmake variable by default on Linux and adds performancelog.write to ConfigService to enable/disable writing the performace log for profiling algorithms. This also adds performancelog.filename to ConfigService to allow user to specify the filename for the log.

Purpose of work

mantid-profiler will provide a simple function/submodule that will make it easy to use mantid to create --infile (algorithmregister.out) without mantid being present. In the case of mantid being available at runtime, it will be used instead

To test:

  • Add performancelog.write=On to Mantid.user.properties
  • Run any algorithm in mantid, this should create a file with the default name algorithmregister.out with start time and start/stop times of the algorithm.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@searscr searscr force-pushed the ewm7210_updateAlgoTimeRegister branch from 12eb61e to 835d8d3 Compare October 9, 2024 01:06
@searscr searscr added Linux Only Only on Linux ORNL Team Issues and pull requests managed by the ORNL development team labels Oct 9, 2024
@searscr searscr added this to the Release 6.12 milestone Oct 9, 2024
@searscr searscr marked this pull request as ready for review October 10, 2024 13:40
@mpatrou mpatrou self-requested a review October 10, 2024 18:08
Copy link
Contributor

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@SilkeSchomann SilkeSchomann self-assigned this Oct 11, 2024
@SilkeSchomann SilkeSchomann merged commit 7b598eb into main Oct 11, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the ewm7210_updateAlgoTimeRegister branch October 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux Only Only on Linux ORNL Team Issues and pull requests managed by the ORNL development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants