Skip to content

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Oct 9, 2024

Description of work

rstcheck is failing with exit code -11 after Python updated to 3.13 in the conda environment used for the pre-commit PR check. Here we pin to 3.12 to avoid the issue.

There is no associated issue.

To test:

Ensure rstcheck is run and passes in the PR check on Jenkins. Verify that python is pinned to 3.12 in the pre-commit conda environment.

This does not require release notes because it's a fix to a build script.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson changed the title pin pre-commit in pre-commit PR script Fix pre-commit PR check Oct 9, 2024
@thomashampson thomashampson force-pushed the fix_rstcheck branch 2 times, most recently from 2b8a984 to 395496c Compare October 9, 2024 10:06
@thomashampson thomashampson added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Oct 9, 2024
@thomashampson thomashampson changed the base branch from main to release-next October 9, 2024 10:28
@thomashampson thomashampson added DevOps Issues and pull requests related to DevOps Dependencies Pull requests that update a dependency file ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions labels Oct 9, 2024
@thomashampson thomashampson added this to the Release 6.11 milestone Oct 9, 2024
@thomashampson thomashampson marked this pull request as ready for review October 9, 2024 10:32
@SilkeSchomann SilkeSchomann self-requested a review October 9, 2024 10:32
@SilkeSchomann SilkeSchomann self-assigned this Oct 9, 2024
Copy link
Contributor

@SilkeSchomann SilkeSchomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that after pinning python to 3.12 in the pre-commit conda rstcheck passes.

@thomashampson thomashampson merged commit 0e061cb into release-next Oct 9, 2024
10 checks passed
@thomashampson thomashampson deleted the fix_rstcheck branch October 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants