-
Notifications
You must be signed in to change notification settings - Fork 128
AlgoTimeRegister addtime/Init export to python #38175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi, @mpatrou, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
8d3eb82
to
345ac43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected, documentation explains usage well.
I've added a milestone. All PRs pointed at main that are not draft need to have a milestone for the audit trail. |
Description of work
AlgoTimeRegister C++ class is exported to python:
addTime() and Instance() functions.
Summary of work
The AlgoTimeRegister is exposed in python, to allow users to measure time in python.
Further detail of work
for Expose Mantid::Instrumentation::AlgoTimeRegister to python
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.
This needs to be merged after Enable Profiling on Linux #38164