Skip to content

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Oct 14, 2024

Description of work

Use new options from DiffractionFocussing added in #38154 in AlignAndFocusPowder.

I added a unittest for ragged binning in AlignAndFocusPowder but it is also covered by existing system tests, e.g. AlignAndFocusPowderFromFilesTest.VulcanRaggedInD

Summary of work

Fixes 7072: AlignAndFocusPowder supplies DiffractionFocussing binning parameters

Further detail of work

To test:

Modifying the usage example you can play with the parameters and see the the log information shows this is running correctly.

PG3_9830_event = Load('PG3_9830_event.nxs')
out = AlignAndFocusPowder(PG3_9830_event, CalFileName='pg3_mantid_det.cal', DeltaRagged='0.1',DMin="0.5,0.35,0.3,0.28",DMax="3.5,1.3,1,0.85")

and the output log shows

AlignAndFocusPowder-[Information] running DiffractionFocussing(PreserveEvents=1 XMin=0.5,0.35,0.3,0.28 XMax=3.5,1.3,1,0.85 Delta=0.1) started at 2024-Oct-14 01:58:45.475956000

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rosswhitfield rosswhitfield marked this pull request as ready for review October 14, 2024 04:23
@sf1919 sf1919 added this to the Release 6.12 milestone Oct 14, 2024
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs in the manual test show the rebin parameters are being passed on to DiffractionFocussing

running DiffractionFocussing(PreserveEvents=1 XMin=0.5,0.35,0.3,0.28 XMax=3.5,1.3,1,0.85 Delta=0.1) started at 2024-Oct-14 17:45:36.157009000

@AndreiSavici AndreiSavici merged commit d383b13 into mantidproject:main Oct 14, 2024
10 checks passed
@rosswhitfield rosswhitfield deleted the AlignAndFocusPowder_use_new_ragged branch October 15, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants