Skip to content

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Oct 15, 2024

Description of work

This PR fixes the remaining wild imports in the Framework directory, as well as all the wild imports in the Testing directory. There are still more wild imports to be fixed, so I cannot yet remove the F403 flag from the pyproject.toml. I will open another PR to continue with removing the wild imports in other directories.

To test:

Code review - check that all imports look correct.

Run ruff locally on all files using the following terminal command

pre-commit run ruff --all-files

Check that this build packages from branch pipeline job passes:
https://builds.mantidproject.org/job/build_packages_from_branch/932/

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Oct 15, 2024
@robertapplin robertapplin added this to the Release 6.12 milestone Oct 15, 2024
@robertapplin robertapplin force-pushed the 0-wild-imports2 branch 25 times, most recently from 13dd6dd to 4d7707c Compare October 18, 2024 12:44
@robertapplin robertapplin changed the title Remove more wild imports Remove wild imports in Framework and Testing directories Oct 18, 2024
@robertapplin robertapplin added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Oct 18, 2024
@robertapplin robertapplin marked this pull request as ready for review October 21, 2024 10:25
@jhaigh0 jhaigh0 self-assigned this Oct 21, 2024
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a few questions but otherwise looks good

Comment on lines -64 to 66
#

# ruff: noqa: F403 # Allow wild imports
from SCons.Script import *
from SCons.Builder import Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what's going on here? Where does SCons come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea if this file is actually used, or what it is used for! @thomashampson do you know?

I'm also not sure where SCons comes from (maybe this is an indication that it is unused)

@SilkeSchomann SilkeSchomann self-assigned this Oct 22, 2024
@SilkeSchomann SilkeSchomann merged commit 94f78bf into main Oct 22, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 0-wild-imports2 branch October 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants