-
Notifications
You must be signed in to change notification settings - Fork 128
Remove wild imports in Framework
and Testing
directories
#38193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13dd6dd
to
4d7707c
Compare
Framework
and Testing
directories
4d7707c
to
a96744f
Compare
a96744f
to
5b68da8
Compare
5b68da8
to
9089bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a few questions but otherwise looks good
...k/PythonInterface/test/python/plugins/algorithms/WorkflowAlgorithms/SANSFitShiftScaleTest.py
Show resolved
Hide resolved
Testing/SystemTests/tests/framework/ISISReflectometryAutoreductionTest.py
Show resolved
Hide resolved
# | ||
|
||
# ruff: noqa: F403 # Allow wild imports | ||
from SCons.Script import * | ||
from SCons.Builder import Builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what's going on here? Where does SCons
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea if this file is actually used, or what it is used for! @thomashampson do you know?
I'm also not sure where SCons
comes from (maybe this is an indication that it is unused)
Description of work
This PR fixes the remaining wild imports in the
Framework
directory, as well as all the wild imports in theTesting
directory. There are still more wild imports to be fixed, so I cannot yet remove the F403 flag from thepyproject.toml
. I will open another PR to continue with removing the wild imports in other directories.To test:
Code review - check that all imports look correct.
Run ruff locally on all files using the following terminal command
Check that this build packages from branch pipeline job passes:
https://builds.mantidproject.org/job/build_packages_from_branch/932/
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.