-
Notifications
You must be signed in to change notification settings - Fork 128
Add phase table model #38195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add phase table model #38195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looks great and is functionally all working well when I ran the manual tests through.
I noticed one typo in the phasequad thread properties, and had a couple of other thoughts when looking through. Let me know what you think. If you feel like it might be worth trying any of them out then I'm very happy to pick up doing that, depending on what you prefer.
...antidqtinterfaces/mantidqtinterfaces/Muon/GUI/Common/phase_table_widget/phase_table_model.py
Outdated
Show resolved
Hide resolved
...dqtinterfaces/mantidqtinterfaces/Muon/GUI/Common/phase_table_widget/phase_table_presenter.py
Outdated
Show resolved
Hide resolved
...dqtinterfaces/mantidqtinterfaces/Muon/GUI/Common/phase_table_widget/phase_table_presenter.py
Outdated
Show resolved
Hide resolved
...dqtinterfaces/mantidqtinterfaces/Muon/GUI/Common/phase_table_widget/phase_table_presenter.py
Outdated
Show resolved
Hide resolved
Move the code that runs the phasequad and phase table calculations on a new thread into the model
Happy with the changes made in the latest commit that move the threading operations to the model 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed the manual testing steps since all changes have been made and everything's working well. All PR comments have been addressed, either by myself or Jonathan, and we've both approved each others changes, so this is ready to be gatekeepered.
Thanks for your hard work with this PR! The code separation between the Presenter and Model is much improved, and the Model also has its own test suite now. |
Description of work
Part of the MVP workshop week.
Adds
PhaseTableModel
which holds an FDA context and some other state, previously in the presenter.Some methods have been moved to the Model if they were only interacting with the context.
Tests updated, and a new test file created for tests only concerning methods now in the model.
Fixes #38104
To test:
Code review and https://developer.mantidproject.org/Testing/MuonAnalysis_test_guides/Muon_FDA.html#id5
This does not require release notes because refactoring change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.