Skip to content

Conversation

MohamedAlmaki
Copy link
Contributor

@MohamedAlmaki MohamedAlmaki commented Oct 16, 2024

Description of work

This PR moves some logic from GroupingTabView to GroupingTabPresenter and adds unit tests for the new function in the presenter.

Fixes #38103.

To test:

  • Make sure the new unit tests pass

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

MohamedAlmaki and others added 2 commits October 15, 2024 11:40
Co-authored-by: Mohammed Almakki <mohammed.almakki@stfc.ac.uk>
Co-authored-by: Despina Ioannide <despina.ioannide@stfc.ac.uk>
@MohamedAlmaki MohamedAlmaki added Muon Issues and pull requests related to muons Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS labels Oct 16, 2024
@MohamedAlmaki MohamedAlmaki added this to the Release 6.12 milestone Oct 16, 2024
@yusufjimoh yusufjimoh self-assigned this Oct 16, 2024
@thomashampson thomashampson marked this pull request as draft October 17, 2024 10:00
@thomashampson
Copy link
Contributor

Marking this as draft while I fix the tests

@thomashampson thomashampson force-pushed the 38103_logic_groupingtabwidgetview branch from d273886 to c0da6c7 Compare October 17, 2024 12:42
@thomashampson thomashampson marked this pull request as ready for review October 17, 2024 13:04
Copy link
Contributor

@yusufjimoh yusufjimoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good, code built successful locally, and all unit tests passed. no release notes are needed, happy to approve the pull request.

@robertapplin
Copy link
Contributor

Thanks for your work on this! The view now contains very little logic, and the logic that it used to have has been moved to the presenter and is under test 👍

@robertapplin robertapplin merged commit 6529ef8 into main Oct 18, 2024
10 checks passed
@MohamedAlmaki MohamedAlmaki deleted the 38103_logic_groupingtabwidgetview branch October 18, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Spectroscopy Issue and pull requests relating to Muons, Indirect and Inelastic at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

Logic in the GroupingTabWidgetView
4 participants