Skip to content

Conversation

GuiMacielPereira
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira commented Oct 17, 2024

Added release notes from changes that were merged during release period.

Description of work

Final touches for release notes for 6.11

Summary of work

Added missing release notes, edited index page, fixed typos and grammatical errors and added a new gif.

Further detail of work

To test:

Build docs-html and read over release notes to look for typos or bad formatting.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

GuiMacielPereira and others added 3 commits October 17, 2024 16:23
Added release notes from changes that were merged during release period.
Corrected grammar, typos and re-worded a few confusing sentences.

Co-authored-by: Sarah Foxley <sarah.foxley@stfc.ac.uk>
@GuiMacielPereira GuiMacielPereira marked this pull request as ready for review October 18, 2024 10:48
@GuiMacielPereira GuiMacielPereira added the Documentation Issues and pull requests related to documentation label Oct 18, 2024
@GuiMacielPereira GuiMacielPereira added this to the Release 6.11 milestone Oct 18, 2024
@GuiMacielPereira
Copy link
Contributor Author

I am still waiting on Richard to make the note about the new algorithm FindMultipleUMatrices clearer

thomashampson and others added 2 commits October 18, 2024 14:10
Co-authored-by: Jonathan Haigh <35813666+jhaigh0@users.noreply.github.com>
@thomashampson thomashampson merged commit 403f41e into release-next Oct 18, 2024
10 checks passed
@thomashampson thomashampson deleted the release-notes-6.11-final-changes branch October 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants