Extracted Logic in Pairing Table View to Presenter

[yusufjimoh]

Description of work

• extracted business logic from the pairing table view to the presenter.
• cleaned up some code in the view and presenter.
• updated unit tests to reflect changes in the view and presenter

Fixes #38105

To test:

• testing instructions are included in the associated issue
• code should pass unit tests

This does not require release notes because it involves code restructuring, no new functionality has been added

[adriazalvarez]

Thanks for the effort on moving the logic out of the view class. I know this view is not easy to refactor ! Generally the view seems more neat and decluttered, although I have found some moved functions that maybe belong in the view, and we could subscribe the presenter to the view to avoid connecting signals/slots on the presenter and use notifiers instead to call the relevant functions on the presenter.

Also, when testing I have found this error when i click on Load current run :

[adriazalvarez]

Except for a typo that is creating a runtime error, I have followed the manual testing instructions without any functional issue on the pair table widget. Thanks for the good work on this refactoring.
I have added some additional comments on small things that I've noticed during review.

[yusufjimoh]

Code has been updated to fix an issue on the pairing table pointed out by @adriazalvarez, Thanks.

[adriazalvarez]

Thanks for the latest changes Yusuf.
I have been testing the pairing table again, everything works as expected.

[adriazalvarez]

I forgot to approve before!

[cailafinn]

Just noticed a couple more improvements that could be made while we're editing these files.

[cailafinn]

Apologies for the late review, I didn't see the notification that the changes had been made.

This implementation of the context manager won't work, unfortunately. Where the with blocks are isn't where the updates need to be stopped. Instead, they should be used in places like add_pair_to_view

    def add_pair_to_view(self, pair, to_analyse=False, color=row_colors[RowValid.valid_for_all_runs], tool_tip=row_tooltips[RowValid.valid_for_all_runs]):
        with self.disable_updates_context():
            self.update_group_selections()
            assert isinstance(pair, MuonPair)
            entry = [str(pair.name), to_analyse, str(pair.forward_group), str(pair.backward_group), str(pair.alpha)]
            self.add_entry_to_table(entry, color, tool_tip)

Which would disable the updates to the view during the time the execution is inside the with block. update_view_from_model would be the other place you'd want to use the context manager. Let me know if you have any questions.

[cailafinn]

Double-checked functionality and seems to be working well, nice work.