Skip to content

Conversation

thomashampson
Copy link
Contributor

Description of work

Removed all used release notes as per instruction in the final bullet point here

There is no associated issue.

To test:

Make sure the correct files are removed

This does not require release notes because it is release notes cleanup


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson marked this pull request as ready for review October 18, 2024 16:22
@thomashampson thomashampson added the Documentation Issues and pull requests related to documentation label Oct 18, 2024
@thomashampson thomashampson added this to the Release 6.11 milestone Oct 18, 2024
@GuiMacielPereira GuiMacielPereira self-requested a review October 18, 2024 16:27
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly removed .gitkeep and .rst files 👍

@RichardWaiteSTFC RichardWaiteSTFC merged commit 913d87e into release-next Oct 18, 2024
10 checks passed
@RichardWaiteSTFC RichardWaiteSTFC deleted the remove_used_release_notes_6_11 branch October 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants