Fix crash on Inelastic Data Processor interface #38257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR fixes multiple crashes on the Inelastic Data Processor interface when trying to load and process invalid data. The crash was caused by not using the "Stop on failure" option in the BatchAlgorithmRunner. When an algorithm failed, it would continue with the processing without recording an error, and hence the crash would occur. We have spotted two crashes, one on the Elwin tab and another on the Moments tab. However, this crash will be present on all the tabs.
Fixes #38255
To test:
Open
Interfaces
->Inelastic
->Data Processor
Go to the Moments tab
Load the following data (this data was created in a weird way, and is not the usual kind of file we use for Indirect/Inelastic)
irs26176_graphite002_red.zip
Click
Run
It should not crash. There should be a red error in the log messages
Also try the instructions in the attached issue:
Save Result
button should be disabled after clickingRun
This does not require release notes because it is a regression since the last release
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.