Skip to content

Conversation

thomashampson
Copy link
Contributor

Description of work

A couple of unit tests (AbinsBroadeningTest and MuonMaxEntTest) starting failing on Windows for no apparent reason:
https://builds.mantidproject.org/view/Nightly%20Pipelines/job/main_nightly_deployment/907/testReport/
There is some output about dividing by zero, and mkl (a math library only in our Windows environments) has updated since the last successful run. It may be that there is a problem with our code, but for now we can pin mkl to the previously working version.

There is no associated issue.

To test:

Make sure the two offending tests run on Windows and pass.

This does not require release notes because it's a dependency pin


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Failing tests:
AbinsBroadeningTest
MuonMaxEntTest (unit test)
@thomashampson thomashampson added this to the Release 6.11 milestone Oct 23, 2024
@thomashampson thomashampson added ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions DevOps Issues and pull requests related to DevOps Dependencies Pull requests that update a dependency file Windows Only Only on Windows High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Oct 23, 2024
@thomashampson thomashampson marked this pull request as ready for review October 23, 2024 10:48
@robertapplin robertapplin self-assigned this Oct 23, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Approving this because the real test is that it passes the Windows PR job

@SilkeSchomann SilkeSchomann self-assigned this Oct 23, 2024
@SilkeSchomann SilkeSchomann merged commit c66b9d7 into release-next Oct 23, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the pin_mkl_to_2024_1_0_release-next branch October 23, 2024 12:26
@thomashampson thomashampson mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Windows Only Only on Windows
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants