Pin mkl to avoid Windows unit test failures with version 2024.2.2 (release-next) #38281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
A couple of unit tests (
AbinsBroadeningTest
andMuonMaxEntTest
) starting failing on Windows for no apparent reason:https://builds.mantidproject.org/view/Nightly%20Pipelines/job/main_nightly_deployment/907/testReport/
There is some output about dividing by zero, and
mkl
(a math library only in our Windows environments) has updated since the last successful run. It may be that there is a problem with our code, but for now we can pinmkl
to the previously working version.There is no associated issue.
To test:
Make sure the two offending tests run on Windows and pass.
This does not require release notes because it's a dependency pin
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.