-
Notifications
You must be signed in to change notification settings - Fork 128
Use Mslice as conda package instead of an external interface #38299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0e22c3d
Use Mslice as conda package instead of an external interface
SilkeSchomann dcf899e
Moved mslice from mantid to mantidworkbench recipe
SilkeSchomann 973a1c4
Add mantid channel to conda build command
SilkeSchomann ac17a1b
Only pass channel to mantid-developer and mantidworkbench
SilkeSchomann 7bb9c80
Removed quotation marks from channel option
SilkeSchomann 84d7f36
Added space after debug option back
SilkeSchomann 954d064
Use classic solver with mamba
SilkeSchomann 182863c
Corrected solver argument
SilkeSchomann 9a87bab
Install classic solver
SilkeSchomann 9405534
Add mantid channel via conda config
SilkeSchomann bc1a78b
Add conda-forge after mantid for higher priority
SilkeSchomann 1c3ca16
Use Mslice with seperate_mslice_test label
SilkeSchomann 3a27c41
Updated copyright year
SilkeSchomann 3b0904e
Only install mslice for workbench
SilkeSchomann d2a2843
Added release note
SilkeSchomann 8e6e1d4
Use mantid/label/main instead of mantid
SilkeSchomann 63e87a0
Updated installers and pinned mslice to 2.10
SilkeSchomann 49076c1
Check for correct MSlice version before building release of Mantid
SilkeSchomann 1ab69ef
Updated mslice interface
SilkeSchomann cf3a54d
Rebased branch
SilkeSchomann 29599d1
Update dev-docs/source/ReleaseChecklist.rst
SilkeSchomann 1bad49e
Update installers/conda/win/create_package.sh
SilkeSchomann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,6 +68,9 @@ numpy: | |
matplotlib: | ||
- 3.8.* | ||
|
||
mslice: | ||
- '2.10' | ||
|
||
ninja: | ||
- '>=1.10.2' | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
docs/source/release/v6.12.0/Direct_Geometry/MSlice/New_features/38299.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- MSlice is now installed via Conda as part of Mantid workbench and not compiled as an external project anymore. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,23 @@ | ||
#!/usr/bin/python | ||
# Mantid Repository : https://github.com/mantidproject/mantid | ||
# | ||
# Copyright © 2018 ISIS Rutherford Appleton Laboratory UKRI, | ||
# Copyright © 2024 ISIS Rutherford Appleton Laboratory UKRI, | ||
# NScD Oak Ridge National Laboratory, European Spallation Source, | ||
# Institut Laue - Langevin & CSNS, Institute of High Energy Physics, CAS | ||
# SPDX - License - Identifier: GPL - 3.0 + | ||
import sys | ||
from mslice.app import show_gui | ||
from mantidqt.gui_helper import get_qapplication | ||
|
||
app, within_mantid = get_qapplication() | ||
show_gui() | ||
if not within_mantid: | ||
sys.exit(app.exec_()) | ||
try: | ||
from mslice.app import show_gui | ||
except ImportError: | ||
from mantid.kernel import logger | ||
|
||
logger.warning("MSlice is not available") | ||
show_gui = None | ||
|
||
if show_gui is not None: | ||
app, within_mantid = get_qapplication() | ||
show_gui() | ||
if not within_mantid: | ||
sys.exit(app.exec_()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will a user experience any different behaviour after this change? i.e do we need a release note detailing the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user should not see any difference in behaviour to before.
For developers, there are two differences: when using the mantid-developer package, they will see a warning when clicking on
MSlice
in the menu instead of the interface. Since MSlice is not developed through the mantid repo, but has its own repo, most developers will not even notice this. The other change is that MSlice is not downloaded from the repo after SHA changes (there won't be SHA changes anymore).