Skip to content
Merged
Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0e22c3d
Use Mslice as conda package instead of an external interface
SilkeSchomann Oct 25, 2024
dcf899e
Moved mslice from mantid to mantidworkbench recipe
SilkeSchomann Oct 25, 2024
973a1c4
Add mantid channel to conda build command
SilkeSchomann Oct 25, 2024
ac17a1b
Only pass channel to mantid-developer and mantidworkbench
SilkeSchomann Oct 25, 2024
7bb9c80
Removed quotation marks from channel option
SilkeSchomann Oct 25, 2024
84d7f36
Added space after debug option back
SilkeSchomann Oct 25, 2024
954d064
Use classic solver with mamba
SilkeSchomann Oct 28, 2024
182863c
Corrected solver argument
SilkeSchomann Oct 28, 2024
9a87bab
Install classic solver
SilkeSchomann Oct 28, 2024
9405534
Add mantid channel via conda config
SilkeSchomann Oct 28, 2024
bc1a78b
Add conda-forge after mantid for higher priority
SilkeSchomann Oct 28, 2024
1c3ca16
Use Mslice with seperate_mslice_test label
SilkeSchomann Oct 28, 2024
3a27c41
Updated copyright year
SilkeSchomann Oct 28, 2024
3b0904e
Only install mslice for workbench
SilkeSchomann Oct 29, 2024
d2a2843
Added release note
SilkeSchomann Oct 29, 2024
8e6e1d4
Use mantid/label/main instead of mantid
SilkeSchomann Oct 29, 2024
63e87a0
Updated installers and pinned mslice to 2.10
SilkeSchomann Oct 30, 2024
49076c1
Check for correct MSlice version before building release of Mantid
SilkeSchomann Oct 30, 2024
1ab69ef
Updated mslice interface
SilkeSchomann Nov 7, 2024
cf3a54d
Rebased branch
SilkeSchomann Nov 12, 2024
29599d1
Update dev-docs/source/ReleaseChecklist.rst
SilkeSchomann Nov 12, 2024
1bad49e
Update installers/conda/win/create_package.sh
SilkeSchomann Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildconfig/Jenkins/Conda/package-conda
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ if [[ $ENABLE_BUILD_WORKBENCH == true ]]; then
if [[ $BUILD_WORKBENCH_WITH_DOCS == false ]]; then
export INCLUDE_MANTIDDOCS=False
fi
conda mambabuild ./mantidworkbench/ $EXTRA_BUILD_OPTIONS
conda mambabuild ./mantidworkbench/ -c mantid/label/main $EXTRA_BUILD_OPTIONS
fi

# elapsed time with second resolution
Expand Down
3 changes: 3 additions & 0 deletions conda/recipes/conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ numpy:
matplotlib:
- 3.8.*

mslice:
- '2.10'

ninja:
- '>=1.10.2'

Expand Down
1 change: 1 addition & 0 deletions conda/recipes/mantidworkbench/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ requirements:
- psutil {{ psutil }}
- {{ pin_compatible("python", max_pin="x.x") }}
- matplotlib {{ matplotlib }}
- mslice {{ mslice }}
- python.app # [osx]
- qtconsole {{ qtconsole }}
- {{ pin_compatible("setuptools", max_pin="x.x") }}
Expand Down
7 changes: 3 additions & 4 deletions dev-docs/source/ReleaseChecklist.rst
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,6 @@ have been fixed. Then:
* Check the release notes and verify that the "Under Construction" paragraph on the main
index page has been removed. Remove the paragraph if it still exists.
* Ensure that all changes, including release notes, have been merged into the ``release-next`` branch.
* On the ``release-next`` branch, check whether the `git SHA
<https://github.com/mantidproject/mantid/blob/release-next/scripts/ExternalInterfaces/CMakeLists.txt>`__
for MSlice is up to date. If not, create a PR to update it and ask a gatekeeper to merge it.
* Make sure the ``release-next`` branch is fully merged into ``main``. If required, manually run the `GitHub workflow
<https://github.com/mantidproject/mantid/actions/workflows/automerge.yml/>`__ using the ``release-next`` branch to
merge the changes.
Expand Down Expand Up @@ -525,7 +522,9 @@ Create Final Release Candidates
###############################

Check with the Quality Assurance Manager that the Smoke testing has been completed, and any issues
have been fixed. The release candidates must now be recreated with their final version numbers. To do this, build the
have been fixed. Additionally, ensure that the version of the ``mslice`` package in ``conda_build_config.yaml`` is correct.
If there have been any updates to MSlice since the last release, it must be released first. The release candidates must
now be recreated with their final version numbers. To do this, build the
`release-next_nightly_deployment Jenkins pipeline
<https://builds.mantidproject.org/view/Nightly%20Pipelines/job/release-next_nightly_deployment/>`__
with the following parameters (most are already defaulted to the correct values):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- MSlice is now installed via Conda as part of Mantid workbench and not compiled as an external project anymore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will a user experience any different behaviour after this change? i.e do we need a release note detailing the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should not see any difference in behaviour to before.

For developers, there are two differences: when using the mantid-developer package, they will see a warning when clicking on MSlice in the menu instead of the interface. Since MSlice is not developed through the mantid repo, but has its own repo, most developers will not even notice this. The other change is that MSlice is not downloaded from the repo after SHA changes (there won't be SHA changes anymore).

2 changes: 1 addition & 1 deletion installers/conda/linux/create_tarball.sh
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ bundle_conda_prefix="$bundle_contents"

echo "Creating Conda environment in '$bundle_conda_prefix'"
"$CONDA_EXE" create --quiet --prefix "$bundle_conda_prefix" --copy \
--channel "$conda_channel" --channel conda-forge --yes \
--channel "$conda_channel" --channel conda-forge --channel mantid --yes \
mantidworkbench \
jq # used for processing the version string
echo
Expand Down
2 changes: 1 addition & 1 deletion installers/conda/osx/create_bundle.sh
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ bundle_conda_prefix="$bundle_contents"/Resources

echo "Creating Conda environment in '$bundle_conda_prefix'"
"$CONDA_EXE" create --quiet --prefix "$bundle_conda_prefix" --copy --platform osx-64 \
--channel "$conda_channel" --channel conda-forge --yes \
--channel "$conda_channel" --channel conda-forge --channel mantid --yes \
mantidworkbench \
jq # used for processing the version string
echo
Expand Down
4 changes: 2 additions & 2 deletions installers/conda/win/create_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ mkdir $COPY_DIR

echo "Creating conda env from mantidworkbench and jq"
"$CONDA_EXE" create --prefix $CONDA_ENV_PATH \
--copy --channel $CONDA_CHANNEL --channel conda-forge -y \
--copy --channel $CONDA_CHANNEL --channel conda-forge --channel mantid -y \
mantidworkbench \
m2w64-jq
echo "Conda env created"
Expand Down Expand Up @@ -170,7 +170,7 @@ rm -f $THIS_SCRIPT_DIR/uninstall_files.nsh
rm -f $THIS_SCRIPT_DIR/uninstall_dirs.nsh

echo "Creating nsis conda env"
"$CONDA_EXE" create --prefix $NSIS_CONDA_ENV_PATH nsis -c conda-forge -y
"$CONDA_EXE" create --prefix $NSIS_CONDA_ENV_PATH nsis -c conda-forge --channel mantid -y
echo "Conda nsis env created"

NSIS_SCRIPT=$THIS_SCRIPT_DIR/project.nsi
Expand Down
20 changes: 14 additions & 6 deletions qt/python/mantidqtinterfaces/mantidqtinterfaces/MSlice.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
#!/usr/bin/python
# Mantid Repository : https://github.com/mantidproject/mantid
#
# Copyright &copy; 2018 ISIS Rutherford Appleton Laboratory UKRI,
# Copyright &copy; 2024 ISIS Rutherford Appleton Laboratory UKRI,
# NScD Oak Ridge National Laboratory, European Spallation Source,
# Institut Laue - Langevin & CSNS, Institute of High Energy Physics, CAS
# SPDX - License - Identifier: GPL - 3.0 +
import sys
from mslice.app import show_gui
from mantidqt.gui_helper import get_qapplication

app, within_mantid = get_qapplication()
show_gui()
if not within_mantid:
sys.exit(app.exec_())
try:
from mslice.app import show_gui
except ImportError:
from mantid.kernel import logger

logger.warning("MSlice is not available")
show_gui = None

if show_gui is not None:
app, within_mantid = get_qapplication()
show_gui()
if not within_mantid:
sys.exit(app.exec_())
5 changes: 0 additions & 5 deletions scripts/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
# External GUIs
add_subdirectory(ExternalInterfaces)

# External projects
include(PyStoG)

Expand Down Expand Up @@ -29,8 +26,6 @@ foreach(_dir ${_pth_dirs})
list(APPEND _pth_list_install "${_scripts_rel_path}/${_dir}")
endforeach()
list(APPEND _pth_list_dev ${CMAKE_CURRENT_BINARY_DIR})
list(APPEND _pth_list_dev ${MSLICE_DEV})
list(APPEND _pth_list_install "${_scripts_rel_path}/ExternalInterfaces")

# development copy
set(_scripts_pth_src "${CMAKE_CURRENT_BINARY_DIR}/mantid-scripts.pth.src")
Expand Down
45 changes: 0 additions & 45 deletions scripts/ExternalInterfaces/CMakeLists.txt

This file was deleted.

Loading