Skip to content

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 28, 2024

@sf1919 sf1919 self-assigned this Oct 29, 2024
@sf1919 sf1919 added this to the Release 6.12 milestone Oct 29, 2024
peterfpeterson
peterfpeterson previously approved these changes Nov 1, 2024
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting update

@sf1919
Copy link
Contributor

sf1919 commented Nov 1, 2024

As this is a ruff change I am waiting for all of @robertapplin ruff related PRs to go in first! Hence why I had not reviewed it yet.

@sf1919
Copy link
Contributor

sf1919 commented Nov 1, 2024

Blocked by #38319 and #38333 and #38345

@robertapplin
Copy link
Contributor

#38319 is waiting for a gatekeeper if anyone has a spare moment :)

@peterfpeterson
Copy link
Member

I doubt that changing the patch level version of ruff will affect these files. A way to find out is to pull the commit into those PRs.

updates:
- [github.com/pre-commit/mirrors-clang-format: v19.1.2 → v19.1.3](pre-commit/mirrors-clang-format@v19.1.2...v19.1.3)
- [github.com/astral-sh/ruff-pre-commit: v0.7.0 → v0.7.2](astral-sh/ruff-pre-commit@v0.7.0...v0.7.2)
@peterfpeterson peterfpeterson force-pushed the pre-commit-ci-update-config branch from b239ef6 to 43d839e Compare November 5, 2024 16:24
@peterfpeterson
Copy link
Member

@sf1919 @robertapplin and I agreed that #38345 can be merged after this.

@robertapplin robertapplin enabled auto-merge (squash) November 5, 2024 16:26
@thomashampson thomashampson self-assigned this Nov 6, 2024
@thomashampson
Copy link
Contributor

test failure is unrelated

@thomashampson thomashampson merged commit d1b467f into main Nov 6, 2024
7 of 10 checks passed
@thomashampson thomashampson deleted the pre-commit-ci-update-config branch November 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants