-
Notifications
You must be signed in to change notification settings - Fork 128
Replace boost end_with and starts_with by C++20 std::string built in functions #38329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4976a0
to
8ac602a
Compare
8ac602a
to
f18761b
Compare
jhaigh0
previously approved these changes
Oct 31, 2024
robertapplin
suggested changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement to the code, just had a few quick questions
Framework/PythonInterface/mantid/kernel/src/Registry/SequenceTypeHandler.cpp
Outdated
Show resolved
Hide resolved
robertapplin
approved these changes
Nov 1, 2024
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Dec 5, 2024
This is a squashed version of mantidproject#38329 Use iends_with for consistency with the rest of the file. Update dev docs regarding string libraries Replace boost starts_with with stl equivalent Add boost headers where they're required Use to std::string to avoid using boost starts_with fix cppcheck defects Add missing boost headers to tests Make strings const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ISIS: Core
Issue and pull requests at ISIS that relate to Core features and functions
Maintenance
Unassigned issues to be addressed in the next maintenance period.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Since our move to C++20, the string functions
starts_with
andends_with
are now available as part ofstd::string
. Here we replace all instances of the boost equivalents. Note that the case insensitive versions (istarts_with
andiends_with
) have not been replaced because there isn't a suitable STL alternative.Summary of work
Things that had to be done as part of this work:
ends_with
andstarts_with
with the STL versionsThere is no associated issue.
To test:
Check that the changes are all sensible. Check the codebase for any missed instances of
boost::algorithm::starts_with
orboost::algorithm::ends_with
.This does not require release notes because it's code maintenance.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.