Skip to content

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Oct 30, 2024

To Gatekeeper: This PR should be squashed when it is merged.

Description of work

Summary of work

Fixes an issue with the builds being output to logs where a failing build would not stop the build from running.

Purpose of work

To fix an issue that resulted from:

There is no associated issue.

Further detail of work

The changes make use of a set -o pipefail command to make any failures in the pipe steam to cause the whole output to fail. This is reset to the default behaviour after the build is done.

To test:

  1. Check that the commit containing a build error fails on the build servers.
  2. Check that the output from the build script is still entered into the log file.

This does not require release notes because there are no user-facing changes


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

By default the return code of a piped command is the result of the last
command in the chain. This isn't what we want here, as the tee command
isn't what we care about the return code for.
@cailafinn cailafinn added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. DevOps Issues and pull requests related to DevOps labels Oct 30, 2024
@cailafinn cailafinn added this to the Release 6.12 milestone Oct 30, 2024
@cailafinn cailafinn marked this pull request as ready for review October 30, 2024 16:12
@thomashampson thomashampson self-assigned this Oct 31, 2024
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the problem. Gatekeeper, please remember to squash the commit and make sure the commit message is good.

@robertapplin robertapplin self-assigned this Oct 31, 2024
@robertapplin robertapplin merged commit 6aadd33 into mantidproject:main Oct 31, 2024
10 checks passed
@cailafinn cailafinn deleted the fix_failing_builds_not_throwing branch November 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants