Skip to content

Fix failing builds not throwing #38330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Fix failing builds not throwing #38330

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f55570b
Fail build command when piped
cailafinn Oct 30, 2024
e241f91
DO NOT MERGE: Fake Build Failure
cailafinn Oct 30, 2024
f0e36ab
Fix example build failure
cailafinn Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions buildconfig/Jenkins/Conda/conda-buildscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,15 @@ if [[ $ENABLE_DOCS == true ]]; then
export LC_ALL=C
fi

# Make sure a failed build command still causes the buildscript to fail after being piped.
set -o pipefail

# Run the script that handles the build
$SCRIPT_DIR/build $WORKSPACE $CMAKE_PRESET $ENABLE_DOCS $ENABLE_DEV_DOCS $ENABLE_BUILD_CODE $ENABLE_UNIT_TESTS $ENABLE_SYSTEM_TESTS $ENABLE_DOC_TESTS $ENABLE_COVERITY "$EXTRA_CMAKE_FLAGS" $BUILD_THREADS | tee $BUILD_DIR/test_logs/build_$OSTYPE.log

# Return to original behaviour.
set +o pipefail

# Run unit and system tests
$SCRIPT_DIR/run-tests $WORKSPACE $ENABLE_SYSTEM_TESTS $ENABLE_UNIT_TESTS $ENABLE_DOCS $ENABLE_DOC_TESTS $BUILD_THREADS

Expand Down
Loading