Skip to content

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Oct 31, 2024

Description of work

This PR fixes any remaining ruff E402 errors, documented here:
https://docs.astral.sh/ruff/rules/module-import-not-at-top-of-file/

It also enables this check to run on all pull requests.

To test:

Code review - check that all changes look reasonable

Run ruff locally on all files using the following terminal command

pre-commit run ruff --all-files

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions labels Oct 31, 2024
@robertapplin robertapplin marked this pull request as ready for review November 1, 2024 14:31
Copy link

github-actions bot commented Nov 1, 2024

👋 Hi, @robertapplin,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Nov 1, 2024
@robertapplin robertapplin removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Nov 1, 2024
@robertapplin robertapplin added this to the Release 6.12 milestone Nov 1, 2024
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the suppressions into individual files

@thomashampson thomashampson merged commit 7ed6f1a into main Nov 5, 2024
10 checks passed
@thomashampson thomashampson deleted the 0-enable-ruff-e402 branch November 5, 2024 16:15
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants