Update Clang to version 18 on macOS #38342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclarkeSTFC
added
macOS Only
jclarkeSTFC
force-pushed
the
38335_clang_18
branch
2 times, most recently
from
227b80d to
941ab38
Compare
jclarkeSTFC
removed
the
macOS Only
cailafinn
previously approved these changes
Nov 21, 2024
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @jclarkeSTFC, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
In Clang 17 a new optimisation was introduced that breaks some of our tests, e.g. SplineSmoothingTest, so I've disabled that option.
This should give us more consistent behaviour across different compilers.
jclarkeSTFC
force-pushed
the
38335_clang_18
branch
from
941ab38 to
e3f9781
Compare
jclarkeSTFC
removed
the
Has Conflicts
|
I rebased due to a merge conflict in |
cailafinn
approved these changes
Nov 25, 2024
sf1919
added
the
macOS Only
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Nov 26, 2024
This brings mantidproject#38342 into ornl-next In Clang 17 a new optimisation was introduced that breaks some of our tests, e.g. SplineSmoothingTest, so I've disabled that option. Use smart pointers instead of raw pointers Disable compiler extensions This should give us more consistent behaviour across different compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of
clangthatconda-forgeuses is now 18, see here.llvm-openmpwas also updated to version 18 for consistency.Fixes #38335.
As well as matching the version of
clangonconda-forge,libc++no longer supportsclangversion 16, see here.To fix a problem casting an
IValidatorto anArrayBoundedValidator<double>we had to disable an optimisation introduced inclang17 with the-fno-assume-unique-vtablesflag. See the release notes here.We also disabled compiler extensions to help maintain code compatibility between different compilers.
To test:
build/CMakeCache.txtmantid-developermetapackage from this branchDouble check that the CI used the correct
clangversion.For the macOS system tests:
https://builds.mantidproject.org/job/build_packages_from_branch/948/
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.