Skip to content

Update Clang to version 18 on macOS #38342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Update Clang to version 18 on macOS #38342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83fec47
Update Clang to version 18 on macOS
jclarkeSTFC Nov 1, 2024
794b974
Use smart pointers instead of raw pointers
jclarkeSTFC Nov 6, 2024
e3f9781
Disable compiler extensions
jclarkeSTFC Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Framework/CurveFitting/src/Functions/BSpline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ void BSpline::resetValidators() {
auto attStartX = getAttribute("StartX");
auto attEndX = getAttribute("EndX");

auto startXValidator = dynamic_cast<BoundedValidator<double> *>(attStartX.getValidator().get());
auto startXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attStartX.getValidator());
startXValidator->setUpper(attEndX.asDouble());

auto endXValidator = dynamic_cast<BoundedValidator<double> *>(attEndX.getValidator().get());
auto endXValidator = std::dynamic_pointer_cast<BoundedValidator<double>>(attEndX.getValidator());
endXValidator->setLower(attStartX.asDouble());

auto breakPointsValidator =
dynamic_cast<ArrayBoundedValidator<double> *>(getAttribute("BreakPoints").getValidator().get());
std::dynamic_pointer_cast<ArrayBoundedValidator<double>>(getAttribute("BreakPoints").getValidator());
breakPointsValidator->setLower(attStartX.asDouble());
breakPointsValidator->setUpper(attEndX.asDouble());
}
Expand Down
1 change: 1 addition & 0 deletions buildconfig/CMake/CommonSetup.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ endif()
# ######################################################################################################################
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

# ######################################################################################################################
# Setup ccache
Expand Down
1 change: 1 addition & 0 deletions buildconfig/CMake/GNUSetup.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ elseif("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
add_definitions(-D_LIBCPP_DISABLE_AVAILABILITY)
# Keep C++14 alignment behaviour while older macOS C++ ABI does not contain the required symbols. Minimum=macos 10.14
add_compile_options(-fno-aligned-new)
add_compile_options(-fno-assume-unique-vtables)
endif()

# Add some options for debug build to help the Zoom profiler
Expand Down
6 changes: 3 additions & 3 deletions conda/recipes/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,17 @@ c_compiler:
- clang # [osx]
- vs2019 # [win]
c_compiler_version: # [unix]
- 16 # [osx]
- 18 # [osx]
- 13 # [linux]
cxx_compiler:
- gxx # [linux]
- clangxx # [osx]
- vs2019 # [win]
cxx_compiler_version: # [unix]
- 16 # [osx]
- 18 # [osx]
- 13 # [linux]
llvm_openmp: # [osx]
- 16 # [osx]
- 18 # [osx]

python:
- 3.10
Expand Down
1 change: 1 addition & 0 deletions docs/source/release/v6.12.0/Workbench/New_features/38335.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Updated compiler on macOS from version 16 to version 18, which should result in performance improvements. See https://releases.llvm.org for release notes.
Loading