-
Notifications
You must be signed in to change notification settings - Fork 128
Add new pearl focus mode allowing user to specify which transverse detector modules to focus #38344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify modules like run numbers e.g. "1-3,5" would be 1,2,3,5. The string will also be used as the focussed workspace suffix
robertapplin
suggested changes
Nov 15, 2024
docs/source/release/v6.12.0/Diffraction/Powder/New_features/38340.rst
Outdated
Show resolved
Hide resolved
robertapplin
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! The code looks good and I've followed the instructions and it works as expected. A test and release note has been added 👍
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Dec 5, 2024
…tector modules to focus (mantidproject#38344) * Add focus mode "trans_subset" to sum select modules * Improve suffix of workspace and support run num string syntax Specify modules like run numbers e.g. "1-3,5" would be 1,2,3,5. The string will also be used as the focussed workspace suffix * Add system test for new focus mode * Add unit test * Add release note * Update PEARL reduction docs * Fix typo in unit test assertion * Fix typo causing bug by not returning string of mod nums * Fix bug slicing list (not arrray) * Change focus mode name to trans_custom After consulting with scientist * Fix typos in docs and use f-string in test * Return early in get_trans_module_indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Added during Sprint
Tasks that were added after initial sprint planning
Diffraction
Issues and pull requests related to diffraction
ISIS: Diffraction
Issue and pull requests relating to Diffraction at ISIS
Powder
Issues and pull requests related to powder diffraction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
New focus mode "trans_custom" added to the PEARL reduction routines which allows user to specify specific modules to include in the transverse bank focussing using the parameter
trans_mod_nums
. The module numbers in the range 1-9 can be specified using the same string syntax as run-numbers - e.g.trans_mod_nums="1-3,5"
corresponds to focussing modules 1,2,3 and 5.Fixes #38340
Report to: Nick Funnell (PEARL, ISIS)
To test:
Use the configs in this folder \olympic\Babylon5\Public\RWaite\PEARLExampleForSarah.zip
(1) Run this script
it should produce these workspaces
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.