Refactor eagroup_context_test for readability and speed - ornl-next #38348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The detector workspaces are now only created once. They are added back into the ADS at the start of each test because the eagroup_context is currently dependent on the ADS. The context and MuonLoadData are cleared in the tearDown method and we assert they are clear. This is a version of mantidproject#38343 into `ornl-next`
peterfpeterson
added
the
Maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detector workspaces are now only created once. They are added back into the ADS at the start of each test because the eagroup_context is currently dependent on the ADS. The context and MuonLoadData are cleared in the tearDown method and we assert they are clear.
This is a version of #38343 into
ornl-next