Skip to content

fix coverity issues in FindReflectometryLines Algorithm #38387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix coverity issues in FindReflectometryLines Algorithm #38387

merged 1 commit into from
Nov 13, 2024

Conversation

yusufjimoh
Copy link
Contributor

Description of work

  • Fix coverity Issue in FindReflectometryLines
  • used std::move to address unnecessary copies

Fixes #38263

To test:

This change does not require release notes because it is a code refactoring focused on performance improvements.

@yusufjimoh yusufjimoh linked an issue Nov 12, 2024 that may be closed by this pull request
Fix coverity issue in FindReflectometryLines #38263
Closed
@yusufjimoh yusufjimoh added the ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS label Nov 12, 2024
@yusufjimoh yusufjimoh added this to the Release 6.12 milestone Nov 12, 2024
@yusufjimoh yusufjimoh added Reflectometry Issues and pull requests related to reflectometry Maintenance Unassigned issues to be addressed in the next maintenance period. labels Nov 12, 2024
@yusufjimoh yusufjimoh marked this pull request as ready for review November 12, 2024 12:28
@yusufjimoh yusufjimoh changed the title fix coverity issues in s fix coverity issues in FindReflectometryLines Algorithm Nov 12, 2024
@rbauststfc rbauststfc self-assigned this Nov 13, 2024
rbauststfc
rbauststfc approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good and all tests are passing. I've also built the changes and tested the algorithm, which seems to be working well.

@robertapplin robertapplin self-assigned this Nov 13, 2024
@robertapplin robertapplin merged commit 00c974d into main Nov 13, 2024
10 checks passed
@robertapplin robertapplin deleted the 38263-fix-coverity-issue-in-findreflectometrylines branch November 13, 2024 11:20
@peterfpeterson peterfpeterson mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbauststfc rbauststfc rbauststfc approved these changes

Assignees

@rbauststfc rbauststfc

@robertapplin robertapplin

Labels
ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 6.12
Development

Successfully merging this pull request may close these issues.

Fix coverity issue in FindReflectometryLines
3 participants
@yusufjimoh @rbauststfc @robertapplin