Elwin Elastic line integration issue #38392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatrou
force-pushed
the
elwin_elastic_integ_fix_ornl
branch
from
ce78f05 to
d420eaf
Compare
for more information, see https://pre-commit.ci
…ct/mantid into elwin_elastic_integ_fix_ornl
|
YQ (cyqjh) is testing it too. |
robertapplin
suggested changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks for fixing this! I can confirm processing is still performed on a background thread and the GUI does not freeze while the tab is running. Just noticed a few things below, then I'm happy to approve
I think this might also need a release note in https://github.com/mantidproject/mantid/tree/main/docs/source/release/v6.12.0/Inelastic/Bugfixes
qt/scientific_interfaces/Inelastic/Processor/ElwinPresenter.cpp
Outdated
Show resolved
Hide resolved
mpatrou
added
Indirect/Inelastic
mpatrou
changed the title
robertapplin
approved these changes
Nov 19, 2024
This was referenced Nov 19, 2024
mpatrou
added a commit
that referenced
this pull request
Nov 25, 2024
Add tests for IqtPresenter tab #37901 Elwin allow processing ILL data #38033 Update Qt connection syntax in Inelastic Interfaces #38119 Update Moments tab instructions and add more tests #38274 Construct the model of OutputPlotOptions widget outside the Presenter class. #38289 Add identifier for output workspaces in Elwin Interface #37762 MVP for the ResNorm tab of the Inelastic Bayes Fitting interface #38357 Remove deprecated Calculate Paalman Pings tab from Inelastic Corrections #38391 Use std::pair instead of QPair in utility files #38396 Elwin Elastic line integration issue #38392 --------- Co-authored-by: adriazalvarez <adrian.diaz-alvarez@stfc.ac.uk> Co-authored-by: Applin <robert.applin@stfc.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
The code fixes with two issues associated to the Elwin tab:
Summary of work
Changes in the Elwin tab include:
Fixes #xxxx.
Further detail of work
IBM EWM: Defect 8108 Mantid Elwin elastic line integration issue
To test:
ORNL --> check with BASIS data
ISIS --> check with existing data for interface freezing and No object found warning
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.